This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
feat(dbt-fal): add fal cloud context #788
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chamini2
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Unrelated question:
def model(dbt, fal):
from utils.get_bool import get_bool
with fal.store_open("test", "w") as f:
f.write("hello world")
df = dbt.ref("model_b")
df["my_bool"] = get_bool()
return dfthe from utils.get_bool import get_bool already works in the cloud, right?
| @@ -37,6 +38,7 @@ def run_with_adapter(code: str, adapter: BaseAdapter, config: RuntimeConfig) -> | |||
| return main( | |||
| read_df=prepare_for_adapter(adapter, read_relation_as_df), | |||
| write_df=prepare_for_adapter(adapter, write_df_to_relation), | |||
| fal_context=FalCloudContext() if is_cloud else None | |||
There was a problem hiding this comment.
I would say the context should always be there, not just for cloud.
class FalContext:
...
class FalCloudContext(FalContext):
... # implement the differences
class FalLocalContext(FalContext):
...There was a problem hiding this comment.
We always thought of these things working the same locally and in the cloud.
| self.options = options | ||
|
|
||
| def __enter__(self): | ||
| self.file = open(self.path, self.options) |
There was a problem hiding this comment.
ATL: is this opening in the /data dir or a temp one in the cloud?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides new cloud context, with
store_openmethod that works likeopenbut in cloud context.